handle other PrepareErrors #788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skgland
force-pushed
the
handle_other_prepare_errors
branch
from
3b3876f to
f67fab2
Compare
Skgland
force-pushed
the
handle_other_prepare_errors
branch
from
f67fab2 to
8119190
Compare
Skgland
force-pushed
the
handle_other_prepare_errors
branch
from
8119190 to
e625c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of rust-lang/rustwide#103 rustwide 0.20 can now also return other PrepareErros than those already handled.
This sorts those into either prepare-fail or broken depending on whether we can identify a known underlying reason and whether that reason is spurious or not.
Spurious and unknown failures are categorized as prepare-fail and known non-spurious errors are classified as broken.
Note rustwide PR rust-lang/rustwide#98 is in progress and aims to reduce the cases that will be falsely classified as prepare-fail instead of broken.